Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props table does not show border on Safari #11698

Closed
robbertkl opened this issue Jul 27, 2020 · 3 comments
Closed

Props table does not show border on Safari #11698

robbertkl opened this issue Jul 27, 2020 · 3 comments

Comments

@robbertkl
Copy link
Contributor

For example, go to the Avatar component on the Storybook Design System using Safari. The props table should show a nice shadow border with rounded corners, but it's missing in Safari.

The underlying reason is that it's a box-shadow and border-radius on the <tbody> element. It seems Safari does not support this. Giving the tbody a display: block does make the shadow appear, but breaks the layout.

Safari screenshot

Screen Shot 2020-07-27 at 15 22 40

Chrome screenshot

Screen Shot 2020-07-27 at 15 22 33

@shilman
Copy link
Member

shilman commented Aug 3, 2020

@domyen can you take a look?

@domyen
Copy link
Member

domyen commented Aug 5, 2020

Got it! We'll need to provide separate styles for Safari (that aren't as handsome) due to limitations with table styling in Webkit.

@shilman
Copy link
Member

shilman commented Aug 5, 2020

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-rc.27 containing PR #11805 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants