Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix menu alignment regression #11469

Merged
merged 1 commit into from
Jul 10, 2020
Merged

UI: Fix menu alignment regression #11469

merged 1 commit into from
Jul 10, 2020

Conversation

domyen
Copy link
Member

@domyen domyen commented Jul 8, 2020

Issue: #11468

What I did

Fix regression by reverting style change in the earlier Composition PR.

How to test

Click on the menu button.

✅ It should look like this:
image

❌ Not this:
image

  • Is this testable with Jest or Chromatic screenshots? No, it requires user interaction to see.

@domyen domyen added the bug label Jul 8, 2020
@shilman shilman added the ui label Jul 8, 2020
@shilman shilman added this to the 6.0 composition milestone Jul 10, 2020
@shilman shilman changed the title #11468 revert style change from earlier PR that introduced a bug UI: Fix menu alignment regression Jul 10, 2020
shilman
shilman approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit b2794fe into next Jul 10, 2020
@shilman shilman mentioned this pull request Jul 10, 2020
Closed
@stof stof deleted the fix-sidebar-tooltip-alignment branch May 25, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
bug ui
Projects
None yet
Milestone
6.0 composition
Development

Successfully merging this pull request may close these issues.
3 participants
@domyen @shilman @ndelangen