-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD docs for composition feature #10691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A few suggestions inline
import { addons } from '@storybook/addons'; | ||
|
||
addons.setConfig({ | ||
mapper: (ref, story) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to storyMapper
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work on this today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
Co-authored-by: Michael Shilman <[email protected]>
…ok into add/composition-docs # Conflicts: # docs/src/pages/configurations/composition/index.md
Waiting for #10780 to be approved and merged before merging this. |
What I did
#10528 #9210 #10504
I added docs
(some of the described features aren't fully implemented yet)