Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD docs for composition feature #10691

Merged
merged 4 commits into from
May 15, 2020
Merged

ADD docs for composition feature #10691

merged 4 commits into from
May 15, 2020

Conversation

ndelangen
Copy link
Member

What I did

#10528 #9210 #10504

I added docs

(some of the described features aren't fully implemented yet)

  • discuss mapper & add tests
  • add auto-loading feature

@ndelangen ndelangen added this to the 6.0 milestone May 8, 2020
@ndelangen ndelangen requested a review from shilman May 8, 2020 15:09
@ndelangen ndelangen self-assigned this May 8, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few suggestions inline

import { addons } from '@storybook/addons';

addons.setConfig({
mapper: (ref, story) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to storyMapper?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll work on this today

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

docs/src/pages/configurations/composition/index.md Outdated Show resolved Hide resolved
ndelangen added 2 commits May 14, 2020 12:00
…ok into add/composition-docs

# Conflicts:
#	docs/src/pages/configurations/composition/index.md
@ndelangen
Copy link
Member Author

Waiting for #10780 to be approved and merged before merging this.

@ndelangen ndelangen merged commit 123476b into next May 15, 2020
@ndelangen ndelangen deleted the add/composition-docs branch May 15, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants