-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition: Update UI for refs #10504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmckeb
force-pushed
the
feature/ref-ui-updates
branch
from
April 21, 2020 17:57
8f9cd84
to
bb52a80
Compare
mrmckeb
requested review from
alterx,
igor-dv,
thani-sh and
tmeasday
as code owners
April 21, 2020 18:00
ndelangen
commented
Apr 22, 2020
@@ -82,7 +85,7 @@ export const init: ModuleFn = ({ store, provider }) => { | |||
findRef: (source) => { | |||
const refs = api.getRefs(); | |||
|
|||
return Object.values(refs).find(({ url }) => `${url}/iframe.html`.match(source)); | |||
return Object.values(refs).find(({ url }) => url.match(source)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filename matching business is now handled by the channel
…book into feature/ref-ui-updates # Conflicts: # lib/ui/src/components/sidebar/Loader.tsx # lib/ui/src/components/sidebar/RefBlocks.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #10340.
This PR adds collapsible sections, updates title capitalization and spacing, and adds five loaders.
Loaders are randomly indented by 0 or 1 levels, with the first always being level 0.