Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition: Update UI for refs #10504

Merged
merged 15 commits into from
Apr 22, 2020
Merged

Composition: Update UI for refs #10504

merged 15 commits into from
Apr 22, 2020

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Apr 21, 2020

Relates to #10340.

This PR adds collapsible sections, updates title capitalization and spacing, and adds five loaders.

Loaders are randomly indented by 0 or 1 levels, with the first always being level 0.

@mrmckeb mrmckeb force-pushed the feature/ref-ui-updates branch from 8f9cd84 to bb52a80 Compare April 21, 2020 17:57
@mrmckeb mrmckeb marked this pull request as ready for review April 21, 2020 18:00
@mrmckeb mrmckeb changed the title Feature/ref ui updates Update UI for refs Apr 21, 2020
@shilman shilman changed the title Update UI for refs Composition: Update UI for refs Apr 22, 2020
@@ -82,7 +85,7 @@ export const init: ModuleFn = ({ store, provider }) => {
findRef: (source) => {
const refs = api.getRefs();

return Object.values(refs).find(({ url }) => `${url}/iframe.html`.match(source));
return Object.values(refs).find(({ url }) => url.match(source));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename matching business is now handled by the channel

…book into feature/ref-ui-updates

# Conflicts:
#	lib/ui/src/components/sidebar/Loader.tsx
#	lib/ui/src/components/sidebar/RefBlocks.tsx
@ndelangen ndelangen merged commit f95829a into next Apr 22, 2020
@ndelangen ndelangen deleted the feature/ref-ui-updates branch April 22, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants