Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded webpack PostCSS plugin definition #1062

Merged
merged 2 commits into from
May 19, 2017
Merged

Upgraded webpack PostCSS plugin definition #1062

merged 2 commits into from
May 19, 2017

Conversation

danielduan
Copy link
Member

Issue: #1061 No PostCSS config found

What I did

It seems like either the config is defined differently in Webpack 2 or we upgraded to a newer version of PostCSS. PostCSS can't read our current plugin definition so I upgraded it to the latest listed on the docs.

How to test

  1. create a story, then create a css file for the story.
  2. put some test styles in the css.
  3. in the story, either import 'styles.css', or require('styles.css').

it should not throw an error during build and console log the style-loader contents.

@danielduan danielduan merged commit a47d8d1 into storybookjs:master May 19, 2017
@ndelangen
Copy link
Member

First merge! 🍾

@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants