-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.0-alpha.0 No PostCSS Config found #1061
Comments
Hello! Webpack noob here! Is the following related to your issue? I encountered this with v3.0.0-alpha on a fresh react-native project. It mentions
|
@dmueller39 No, that's been fixed already with this PR and merged. I had that problem too. If you can't wait for a new alpha to be released, go into your Here's the correct version, the last line needs to be updated:
|
@danielduan thanks for clarifying. |
@danielduan AFAICT, the two issues are unrelated. This one seems to be related to the webpack2 API, which only allows certain properties for its config objects. It complains about the |
@MasterAM you are correct. I should have clarified when I answered the question. I do have a PR open for the PostCSS issue. |
It's merged and released as |
@ndelangen I'm still getting the
|
@matt-oakes thanks. Looks like the react-native project still uses the old plugin schema. reopening this ticket. @ndelangen can you take a look? I don't have any native projects set up to test. |
Thanks for reopening this @danielduan. I have had a go at fixing the issue with my extremely limited webpack knowledge. |
I think this is now fixed, Will do a new alpha release for you @matt-oakes |
@ndelangen unrelated to this issue, but is |
If you needed it before, you still need it now. We publish with lerna, and do not publish a package that has not been changed since last publish. So it's fine for package to not be exactly the same, if it's the last alpha you're OK. Easy way to install last alpha is like so: npm i @storybook/addons@alpha --save |
The new alpha works great and fixes this issue. The only slight hiccup I had was that Thanks for the good work! I'm looking forward to trying this with React Native! |
Hey, that sounds like a pretty easy fix! Do you dare touch our codebase @matt-oakes and make a PR adding react-dom to the cli? Do you need react-dom for react-native?!? |
You need it for the browser UI to work. If you don't have it and open the browser you get some lovely lovely errors! I'll open a new issue to track it and look into fixing it tomorrow. |
I have a wrapper component that styles different backgrounds and padding/margins that imports a CSS file and lives in the
/stories
folder.I think PostCSS loader deprecated the use of plugin definition in our
default/webpack.config.js
so we need to define this as a separate filepostcss.config.js
.When I have time, i'll take a shot at fixing it.
The text was updated successfully, but these errors were encountered: