-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0.0] Prop type error in the console when resizing browser window to less than 600px #5910
Comments
Huzzah!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.35 containing PR #6241 that references this issue. Upgrade today to try it out! Because it's a pre-release you can find it on the |
I'm still seeing this same error with v5.1.8
|
Can this bot be instructed to not treat the issue labelled as "bug" as inactive? 🤔 |
@web-padawan yes if you add the label "in progress". but AFAIK is not in progress. |
Hi all. I and my company front staff also faced this issue. It's not appropriate for our stakeholders to have this warning. We work hard on code quality and pay attention to any warning in console, which is important for us and our clients. If you are not going to resolve the following issue, please let us know so we can look for another platform. But we would like to see the issue resolved in yours. |
+1 if it would be more critical to me I'd investigate further but it's mostly a small nuisance at this point |
+1 this issue |
+1 |
Is this still an issue in 5.2? |
It still appears in 5.2 for me |
Can confirm I'm seeing this in 5.2 also |
+1 on [email protected] |
+1 this is still an issue in [email protected] |
Still an issue in 5.2.3 |
+1 |
@EdwardStepanian You could use the Storybook Viewport Addon, this way you can still see mobile view and the console won't show the error message. |
@ndelangen Did this regress? #8819 |
What makes you think it did @shilman ? |
@ndelangen That somebody filed #8819 yesterday saying it did |
Was the PR not picked? The new bug report has: This PR: #8583 has the |
I'll fix this on master too |
Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.7 containing PR #8941 that references this issue. Upgrade today to try it out! Closing this issue. Please re-open if you think there's still more to do. |
Describe the bug
The following error appears in the console:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No error in the console
Screenshots
System:
The text was updated successfully, but these errors were encountered: