Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parameters attribute from legacy <Story> being removed #224

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

xeho91
Copy link
Collaborator

@xeho91 xeho91 commented Oct 29, 2024

Fixes #223

📦 Published PR as canary version: 4.1.8--canary.224.6c887e6.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v5.0.0-next.9

Changelog

💥 Breaking Change

🚀 Enhancement

🐛 Bug Fix

  • fix: parameters attribute from legacy <Story> being removed #224 (@xeho91)
  • Fix errors at enhanceRollupError in Vite #222 (@JReinhold)
  • refactor: Replace deprecated context="module" with module #217 (@xeho91)
  • fix(pre-transform): Move stories target component import declaration from instance to module tag #218 (@xeho91)
  • v5: Fix tags being ignored #206 (@JReinhold)
  • fix(parser): Resolve autodocs tag issue and extracting rawCode #201 (@xeho91)
  • Replace lodash usage with es-toolkit #192 (@JReinhold)
  • chore: use dist folder to load the files #185 (@benoitf)

⚠️ Pushed to next

  • fix typing issue in Example.stories.svelte (@xeho91)
  • remove obsolete test (@xeho91)

🏠 Internal

  • refactor: Improve AST-related types readability & fix existing issues #209 (@xeho91)

Authors: 4

@JReinhold JReinhold added bug Something isn't working patch Increment the patch version when merged labels Oct 29, 2024
@JReinhold JReinhold merged commit e9c7cd2 into next Oct 29, 2024
6 of 7 checks passed
@JReinhold JReinhold deleted the fix-legacy-story-parameters branch October 29, 2024 07:54
@shilman
Copy link
Member

shilman commented Oct 29, 2024

🚀 PR was released in v5.0.0-next.9 🚀

@shilman shilman added the prerelease This change is available in a prerelease. label Oct 29, 2024
@xeho91 xeho91 linked an issue Nov 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [next] Legacy Story parameters is being removed in pre-transform
3 participants