Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash usage with es-toolkit #192

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

JReinhold
Copy link
Collaborator

@JReinhold JReinhold commented Jul 21, 2024

#186 introduces usage of es-toolkit. This PR replaces the one place we use lodash-es (get) with the compat get from es-toolkit, to remove lodash from the dependency list.

The emit code functionality is heavily unit tested, and everything seems to work without issues.

📦 Published PR as canary version: 4.1.5--canary.192.7a0174d.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@JReinhold JReinhold self-assigned this Jul 21, 2024
@JReinhold JReinhold requested a review from xeho91 July 21, 2024 21:21
Copy link
Collaborator

@xeho91 xeho91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're fast!

I was about to subtly mention this library to you when we get in touch again 😁, but I think you already knew 🙂

@JReinhold JReinhold merged commit 7a0174d into restore-template-component Jul 22, 2024
6 of 7 checks passed
@shilman
Copy link
Member

shilman commented Oct 16, 2024

🚀 PR was released in v5.0.0-next.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants