fix: copy src into dist in w3up-client #1239
Merged
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue in a Next.js app that seems to a result of having sourcecode and type declarations in separate directories: ``` ./node_modules/.pnpm/@web3-storage[email protected]/node_modules/@web3-storage/w3up-client/src/types.ts:15:29 Type error: Could not find a declaration file for module './client.js'. '/Users/travis/dev/pl/fetch-test/node_modules/.pnpm/@web3-storage[email protected]/node_modules/@web3-storage/w3up-client/src/client.js' implicitly has an 'any' type. 13 | Unit, 14 | } from '@ucanto/interface' > 15 | import { type Client } from './client.js' | ^ ``` Copying the sourcecode into `dist` and updating exports to point to it seems to fix this.
gobengo
approved these changes
Dec 13, 2023
very unclear why this is needed, especially since it didn't seem to be needed before I made the package.json changes, but this fixes the build!
the previous one was giving TSC a hard time
travis
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## [12.0.0](w3up-client-v11.2.1...w3up-client-v12.0.0) (2024-01-03) ### ⚠ BREAKING CHANGES * return allocated bytes in `store/add` receipt ([#1213](#1213)) ### Features * expose OwnedSpace and SharedSpace from access-client ([#1244](#1244)) ([8ec1b44](8ec1b44)) * return allocated bytes in `store/add` receipt ([#1213](#1213)) ([5d52e44](5d52e44)) ### Fixes * copy src into dist in w3up-client ([#1239](#1239)) ([468bb79](468bb79)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue in a Next.js app that seems to be a result of having sourcecode and type declarations in separate directories:
Copying the sourcecode into
distand updating exports to point to it seems to fix this.