Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy src into dist in w3up-client #1239

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix: copy src into dist in w3up-client #1239

merged 3 commits into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. fix: copy src into dist in w3up-client 

    I ran into an issue in a Next.js app that seems to a result of having sourcecode and type declarations in separate directories:

```
./node_modules/.pnpm/@web3-storage[email protected]/node_modules/@web3-storage/w3up-client/src/types.ts:15:29
Type error: Could not find a declaration file for module './client.js'. '/Users/travis/dev/pl/fetch-test/node_modules/.pnpm/@web3-storage[email protected]/node_modules/@web3-storage/w3up-client/src/client.js' implicitly has an 'any' type.

  13 |   Unit,
  14 | } from '@ucanto/interface'
> 15 | import { type Client } from './client.js'
     |                             ^
```

Copying the sourcecode into `dist` and updating exports to point to it seems to fix this.
    @travis
    travis committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8742005 View commit details
    Browse the repository at this point in the history

  2. fix: ignore Delegation class in code coverage 

    very unclear why this is needed, especially since it didn't seem
to be needed before I made the package.json changes, but this fixes the build!
    @travis
    travis committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a3aa457 View commit details
    Browse the repository at this point in the history

  3. fix: switch to a different style of c8 ignore 

    the previous one was giving TSC a hard time
    @travis
    travis committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    96acc59 View commit details
    Browse the repository at this point in the history