Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): add rule to check if the AsyncAPI document is using the latest version #2282

Merged

Conversation

magicmatatjahu
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

  • check if given AsyncAPI document is using the latest version

@magicmatatjahu magicmatatjahu added enhancement New feature or request AsyncAPI Issues related to the AsyncAPI ruleset labels Sep 17, 2022
@magicmatatjahu magicmatatjahu requested a review from a team as a code owner September 17, 2022 10:31
@magicmatatjahu magicmatatjahu force-pushed the asyncapi/inform-about-last-version branch from 15d65ec to 4491574 Compare September 17, 2022 10:32
@magicmatatjahu magicmatatjahu changed the title refactor: add rule to check if the AsyncAPI document is using the latest version. feat(rulesets): add rule to check if the AsyncAPI document is using the latest version. Sep 17, 2022
@magicmatatjahu magicmatatjahu force-pushed the asyncapi/inform-about-last-version branch from 4491574 to ebbf782 Compare September 17, 2022 10:33
P0lip
P0lip previously approved these changes Sep 22, 2022
@P0lip
Copy link
Contributor

P0lip commented Sep 22, 2022

@magicmatatjahu I think you'll need to update the version in asyncapi2-streetlights.scenario

@magicmatatjahu magicmatatjahu force-pushed the asyncapi/inform-about-last-version branch from ebbf782 to c13d7ab Compare September 23, 2022 12:50
@magicmatatjahu magicmatatjahu changed the title feat(rulesets): add rule to check if the AsyncAPI document is using the latest version. feat(rulesets): add rule to check if the AsyncAPI document is using the latest version Sep 23, 2022
@magicmatatjahu magicmatatjahu requested a review from a team as a code owner September 23, 2022 13:05
@magicmatatjahu magicmatatjahu force-pushed the asyncapi/inform-about-last-version branch from 08f2f5c to fb31394 Compare September 23, 2022 13:23
@magicmatatjahu magicmatatjahu force-pushed the asyncapi/inform-about-last-version branch from fb31394 to bb36109 Compare September 23, 2022 13:23
@magicmatatjahu
Copy link
Contributor Author

@P0lip Thanks! Done, could you check again? :)

@P0lip P0lip merged commit 366779f into stoplightio:develop Sep 23, 2022
@magicmatatjahu magicmatatjahu deleted the asyncapi/inform-about-last-version branch September 23, 2022 13:30
stoplight-bot pushed a commit that referenced this pull request Sep 26, 2022
# [@stoplight/spectral-rulesets-v1.13.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.12.0...@stoplight/spectral-rulesets-v1.13.0) (2022-09-26)

### Features

* **rulesets:** add rule to check if the AsyncAPI document is using the latest version ([#2282](#2282)) ([366779f](366779f))
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-rulesets-v1.13.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AsyncAPI Issues related to the AsyncAPI ruleset enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants