-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rulesets): check uniqueness of AsyncAPI messages #2224
feat(rulesets): check uniqueness of AsyncAPI messages #2224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the doc file with one small change.
1c15a52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Apologies for a delay - was taking time off, and this one felt through my cracks. |
# [@stoplight/spectral-rulesets-v1.12.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.11.3...@stoplight/spectral-rulesets-v1.12.0) (2022-08-24) ### Features * **rulesets:** check uniqueness of AsyncAPI messages ([#2224](#2224)) ([297531b](297531b))
🎉 This PR is included in version @stoplight/spectral-rulesets-v1.12.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
@P0lip @pamgoodrich Thanks for review and suggestion! Just today I saw this review but I also saw that it is merged 😄 Nothing is wrong, we help in this project so we can wait :) |
Fixes #2223
Checklist
Does this PR introduce a breaking change?
Part of #2100
Add rule to check uniqueness
messageId
of AsyncAPI messages.Bad Example
Good Example
Also fix rule for
operationId
uniqueness - checkoperationId
in operation's traits.cc @smoya @jonaslagoni