Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve ApplicationSet template finalizers #190

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Preserve ApplicationSet template finalizers #190

merged 2 commits into from
Apr 25, 2024

Conversation

amisstea
Copy link
Contributor

These changes:

  1. Make it possible for ClusterTemplate admins to implement workarounds involving ArgoCD finalizers, specifically PostDelete Hook not work with Application generated from ApplicationSet argoproj/argo-cd#17181 (comment).
  2. Fix a minor bug that was causing one of the test cases to consistently fail

@amisstea
Initialize destination namespace labels
8b6fd6a 
This fixes the `Label destionation namespace - same as CTI` test and
a possible bug scenario.

Signed-off-by: Alex Misstear <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2024

Hi @amisstea. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amisstea
Copy link
Contributor Author

@rawagner PTAL

@amisstea amisstea force-pushed the remove-argocd-finalizer branch from 8fb0ee3 to 7ce2e93 Compare April 24, 2024 14:45
@amisstea amisstea changed the title Remove argocd finalizer Preserve ApplicationSet template finalizers Apr 24, 2024
@amisstea amisstea force-pushed the remove-argocd-finalizer branch from 7ce2e93 to 4244609 Compare April 24, 2024 15:30
@amisstea
Preserve ApplicationSet template finalizers
89301ff 
This allows ApplicationSet admins to customize the finalizers while ensuring
`resources-finalizer.argocd.argoproj.io` is always applied for proper cleanup.

Signed-off-by: Alex Misstear <[email protected]>
@amisstea amisstea force-pushed the remove-argocd-finalizer branch from 4244609 to 89301ff Compare April 24, 2024 15:40
@rawagner
Copy link
Collaborator

/ok-to-test

@rawagner
Copy link
Collaborator

/retest

1 similar comment
@rawagner
Copy link
Collaborator

/retest

@rawagner
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisstea, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ea9ff44 into stolostron:main Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner left review comments

Assignees

@rawagner rawagner

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amisstea @rawagner