Remove finalizer from ApplicationSetTemplate

ArgoCD automatically sets the `resources-finalizer.argocd.argoproj.io` finalizer on the generated Application so this was redundant. Removing it grants ClusterTemplate admins control over the finalizers on their ApplicationSets should they wish to customize them. Signed-off-by: Alex Misstear <[email protected]>
stolostron · Apr 23, 2024 · 8fb0ee3 · 8fb0ee3
1 parent 8b6fd6a
commit 8fb0ee3
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/api/v1alpha1/clustertemplateinstance_utils.go b/api/v1alpha1/clustertemplateinstance_utils.go
@@ -183,9 +183,6 @@ func (i *ClusterTemplateInstance) UpdateApplicationSet(
 		Template: argo.ApplicationSetTemplate{
 			ApplicationSetTemplateMeta: argo.ApplicationSetTemplateMeta{
 				Name: name,
-				Finalizers: []string{
-					argo.ResourcesFinalizerName,
-				},
 				Labels: map[string]string{
 					CTINameLabel:      i.Name,
 					CTINamespaceLabel: i.Namespace,