-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per Domain Isolation Rules Wildcard process order #240
Comments
You're right, that would be ideal. But I don't think it's possible to determine that reliably. I guess we need a way to reorder the rules. |
It could be sorted automatically with the most specific entries at the top, like this:
|
@anewuser How exactly would you approach the determining of "specific"? The only thing that comes to mind is the length of the pattern, where the shortest is the least specific, but that would fail for regexps: e.g. |
I didn't know that you had added support to regexes too. I was thinking only of subdomains, domains and TLDs. I'm going to use that option to keep my list more organized. |
Stricter matches always winning will be too subjective and not always wanted. The best way IMO to deal with priority is to allow user to reorder rules how they want and the priority of rules are in descending order of how they're ordered. That way users can make any rule with the priority they want. |
You can also do the following in global or per domain isolation, what you prefer. And don't use Mouse Click events. |
^^ This is a recipe to break every login where login is provided by external domain. |
I thought we are talking here about duckduckgo.com :) If you create a domain rule for duckduckgo.com, as you described in your post, and set the option as I mentioned above then every link you click on duckduckgo.com will open in a new temporary container. For me a desired operation, of course opinions can differ and it was only a suggestion showing you an different approach. If you set the option globally you can always make domain rules for your external login domains to overrule this behaviour. Again, only showing a different approach. :) |
@gitthehubs If you are interested, I can share my latest solution here. Cheers |
@crssi |
OK. Picture the following. DuckDuckGo as default search engine. (Set DDG in FF for default search engine and remove any other providers). On any other page, left click should always stay in the same container to avoid login and payments redirection problems. Middle click should always open a new tab in a new container, exception is when target is same domain/subdomain. Rules: Useful shortcuts: Configuration (note: changes to a default settings... reinstall TC for reset to default):
Wildcard domain in Wet dreams would be possibility to start a new container by typing URL in the urlbar (not to confuse with mouse clicking link event), but this cannot be achieved by underlying API limitations which does not distinguish between open link by typing into URL bar and opening by mouse event. Useful additional web extensions: Cheers |
@crssi |
@gitthehubs Cheers |
@stoically should I close this issue or you need it for some reminder (also feel free to close it by yourself). Cheers and thank you for one of the best web extension. |
Thanks! No reason to close since it's a valid and much needed feature request. |
v1.0beta7 allows reordering Per Domain Isolation rules per drag&drop. Let me know if you encounter any issues, thanks! |
@stoically is there anything new to accomplish upper solution? Thank you and wish you best in the 2020. 😄 |
Thanks, you too. As per Bugzilla ticket linked in #327, this isn't something that Firefox wants to support - so nothing I can do, unfortunately. |
Thank you. Sadly WONTFIX should be a new logo for mozilla products. 😢 |
Is it possible that they didn't understand your intentions in the ticket? |
Judging by the answer it seems that |
I see. Thank you |
Hi @stoically
Picture next scenario (fresh install, everything at default <- this is important):
Global Isolation -> Middle Mouse:
If the clicked Link Domain does not match the active Tabs Domain (Subdomains won't get isolated)
Create two per domain isolation rules in that exact order:
Domain pattern
*
Always open in new Temporary Containers:
Enabled
Mouse Clicks on Links should open new Temporary Containers [Left Mouse]:
Use Global
Domain pattern
duckduckgo.com
Always open in new Temporary Containers:
Enabled
Mouse Clicks on Links should open new Temporary Containers [Left Mouse]:
Always
Open
https://duckduckgo.com
and do some search.Left click on some results.
The second rule never fires, since the first rule wins before the second one.
Shouldn't win the rule that has stricter match?
Actual result: click on result link opens a page in the actual container
Expected result: click on a result link should open a page in a NEW container
Workaround is that the upper per domain rules are created in reverse order and we need to be careful in creating a new rules and in that case the reordering rules possibility is missing.
Cheers
The text was updated successfully, but these errors were encountered: