Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolation based on webNavigation.TransitionType #327

Closed
stoically opened this issue Nov 15, 2019 · 6 comments
Closed

Isolation based on webNavigation.TransitionType #327

stoically opened this issue Nov 15, 2019 · 6 comments

Comments

@stoically
Copy link
Owner

stoically commented Nov 15, 2019

Would need the webNavigation permission, though that could be asked on-demand. The list of transition types can be found here. That might be useful to e.g. only trigger isolation when the user entered something into the address bar. The only issue might be that webNavigation.onCommitted has no request id, and hence the decision must be made based on the tabId.

When/If implementing that, it might be worthwhile to consider changing the (Per Domain) Isolation UI to be more like something like Request Control's Rules.

@crssi
Copy link

crssi commented Nov 15, 2019

That is so thrilling. Cannot wait for it. Christmas is coming. 😄 👍

@stoically
Copy link
Owner Author

stoically commented Nov 15, 2019

Welp, sorry to get you hyped @crssi, but it seems I was wrong. While the feature could be implemented, it wouldn't prevent the tab from actually connecting to the remote server (and potentially sending cookies), since the webNavigation.onCommitted docs say At least part of the new document has been received from the server.

I'll look into opening a bugzilla ticket and ask for the needed API changes.

@crssi
Copy link

crssi commented Nov 26, 2019

If you open the bugzilla ticket then, please, make sure you post it here, so I/we can place a vote on bugzilla. 😉

Thank you

@stoically
Copy link
Owner Author

Here's the ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1600069

Putting this issue in the blocked by third-party column for now.

@crssi

This comment has been minimized.

@geeknik
Copy link

geeknik commented Nov 28, 2019

I updated the Mozilla bug from UNCONFIRMED to NEW so it maybe gets picked up quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants