Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Rollup for production builds #165

Merged
merged 18 commits into from
Jan 13, 2022
Merged

Introduce Rollup for production builds #165

merged 18 commits into from
Jan 13, 2022

Conversation

KonnorRogers
Copy link
Contributor

@KonnorRogers KonnorRogers commented Nov 20, 2021 •
edited by marcoroth
Loading

  • Fixes circular dependencies for elements
  • Introduces rollup to catch circular dependencies
  • Clean up github actions by building the NPM package, and caching the Ruby stuff with the new ruby setup.
  • Refactor javascript/action_cable.js into javascript/cable_consumer.js

@KonnorRogers KonnorRogers force-pushed the chore/bundle-for-production branch 2 times, most recently from e03a2e9 to 58c2789 Compare November 20, 2021 18:52
@KonnorRogers KonnorRogers force-pushed the chore/bundle-for-production branch from 58c2789 to 464c353 Compare November 20, 2021 18:54
marcoroth
marcoroth reviewed Dec 28, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@marcoroth marcoroth force-pushed the chore/bundle-for-production branch from d9ada61 to 5902f4e Compare December 28, 2021 19:27
@marcoroth marcoroth changed the title fix: circular dependency, introduce rollup, cleanup GH actions Introduce Rollup for production builds Jan 5, 2022
@marcoroth marcoroth mentioned this pull request Jan 5, 2022
Closed
3 tasks
@marcoroth marcoroth force-pushed the chore/bundle-for-production branch from 384796a to e815536 Compare January 12, 2022 22:16
@marcoroth marcoroth merged commit 9e9bf3e into stimulusreflex:master Jan 13, 2022
@marcoroth marcoroth mentioned this pull request Jan 13, 2022
Merged
3 tasks
@bopm bopm mentioned this pull request Jan 18, 2022
Closed
@marcoroth marcoroth mentioned this pull request Mar 15, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KonnorRogers @marcoroth @leastbad