Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165 reintroducing webpack issue #178

Closed
bopm opened this issue Jan 18, 2022 · 4 comments
Closed

#165 reintroducing webpack issue #178

bopm opened this issue Jan 18, 2022 · 4 comments

Comments

@bopm
Copy link

bopm commented Jan 18, 2022

#165 is reverting changes from #169 which is leading to next error in webpack@5:

ERROR in ./node_modules/stimulus_reflex/node_modules/cable_ready/javascript/index.js 28:2-9
Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)
@bopm
Copy link
Author

bopm commented Jan 20, 2022

@leastbad I am going to tag you here as you were approver of #169 in the first place.

@marcoroth
Copy link
Member

Hey @bopm, thank you for spotting this! This somehow got lost in a merge conflict.

I cherry-picked the commit from #169 as 1bded05 on master!

@bopm
Copy link
Author

bopm commented Jan 27, 2022

@marcoroth Any chance for a new version release? As currently released npm version still lacks this change and contains that code inside of node_modules inside of stimulus_reflex.

@marcoroth
Copy link
Member

Hey @bopm, sorry it took us a while to get this straight. We just released CableReady 5.0.0.pre9 which includes this fix. I'm sorry if this caused any inconvenience in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants