Merge pull request kubernetes-sigs#122 from kahun/fix/node_groups_val…

…idations

Fix node groups

pkg/cmd/kind/create/cluster/validation/commonvalidations.go

@@ -115,12 +115,15 @@ func validateRegistryCredentials(descriptor commons.DescriptorFile, secrets comm
 func quantityValidations(workerNodes commons.WorkerNodes) error {
 	for _, wn := range workerNodes {
 		// Cluster Autoscaler doesn't scale a managed node group lower than minSize or higher than maxSize.
-		if wn.NodeGroupMaxSize < wn.Quantity {
+		if wn.NodeGroupMaxSize < wn.Quantity && wn.NodeGroupMaxSize != 0 {
 			return errors.New("max_size in WorkerNodes " + wn.Name + ", must be equal or greater than quantity")
 		}
 		if wn.Quantity < wn.NodeGroupMinSize {
 			return errors.New("quantity in WorkerNodes " + wn.Name + ", must be equal or greater than min_size")
 		}
+		if wn.NodeGroupMinSize < 0 {
+			return errors.New("min_size in WorkerNodes " + wn.Name + ", must be equal or greater than 0")
+		}
 		if wn.ZoneDistribution == "balanced" || wn.ZoneDistribution == "" {
 			if wn.AZ != "" {
 				return errors.New("az in WorkerNodes " + wn.Name + ", can not be set when HA is required")

pkg/commons/cluster.go

@@ -132,7 +132,7 @@ type WorkerNodes []struct {
 	Spot             bool              `yaml:"spot" validate:"omitempty,boolean"`
 	Labels           map[string]string `yaml:"labels"`
 	NodeGroupMaxSize int               `yaml:"max_size" validate:"required_with=NodeGroupMinSize,numeric,omitempty"`
-	NodeGroupMinSize int               `yaml:"min_size" validate:"required_with=NodeGroupMaxSize,numeric,gt=0,omitempty"`
+	NodeGroupMinSize int               `yaml:"min_size" validate:"required_with=NodeGroupMaxSize,numeric,omitempty"`
 	RootVolume       struct {
 		Size      int    `yaml:"size" validate:"numeric"`
 		Type      string `yaml:"type"`