Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "creating a cluster" section to user guide #122

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Add "creating a cluster" section to user guide #122

merged 1 commit into from
Nov 21, 2018

Conversation

alejandrox1
Copy link
Contributor

/kind documentation

Signed-off-by: Jorge Alarcon Ochoa [email protected]

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @alejandrox1. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alejandrox1
Copy link
Contributor Author

/assign @munnerz

BenTheElder
BenTheElder reviewed Nov 21, 2018
View reviewed changes
docs/user-guide.md

By default, the base image will be tagged as `kindest/base:latest`.
If you want to change this, you can use the `--image` flag.
By default, the cluster will be given the name `kind-1`. "1," here, is the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to self: I think maybe we should stop auto-prefixing this and just use context name directly cc @munnerz 🤔

BenTheElder
BenTheElder reviewed Nov 21, 2018
View reviewed changes
docs/user-guide.md Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2018
@BenTheElder
Copy link
Member

Thanks for working on this again!

@rimusz
Copy link
Contributor

rimusz commented Nov 21, 2018

LGTM
very needed doc 👍

@alejandrox1 alejandrox1 force-pushed the user-guide-create-cmd branch from ff60fd4 to ceaba2e Compare November 21, 2018 13:05
neolit123
neolit123 reviewed Nov 21, 2018
View reviewed changes
cmd/kind/create/create.go Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
cmd/kind/create/cluster/createcluster.go Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
@alejandrox1 alejandrox1 force-pushed the user-guide-create-cmd branch from ceaba2e to ea44a6f Compare November 21, 2018 19:09
BenTheElder
BenTheElder reviewed Nov 21, 2018
View reviewed changes
docs/user-guide.md Outdated Show resolved Hide resolved
@alejandrox1
Add "creating a cluster" section to user guide
94b36f0 
/kind documentation

Signed-off-by: Jorge Alarcon Ochoa <[email protected]>
@alejandrox1 alejandrox1 force-pushed the user-guide-create-cmd branch from ea44a6f to 94b36f0 Compare November 21, 2018 20:03
BenTheElder
BenTheElder approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks again! 🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit f8aa772 into kubernetes-sigs:master Nov 21, 2018
@alejandrox1 alejandrox1 deleted the user-guide-create-cmd branch January 22, 2019 18:34
stg-0 pushed a commit to stg-0/kind that referenced this pull request Jun 20, 2023
@kahun
Merge pull request kubernetes-sigs#122 from kahun/fix/node_groups_val…
c0a2c3c 
…idations

Fix node groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@munnerz munnerz

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alejandrox1 @k8s-ci-robot @BenTheElder @rimusz @neolit123 @munnerz