Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #112

Closed
wants to merge 4 commits into from
Closed

Conversation

Vitormdias
Copy link

Complements PR #106, and resolves issues #72 #92 #94 #99 #102 #109

@SavageWilliam
Copy link

@stevekane are you able to review this

@addaleax
Copy link
Collaborator

Like I mentioned in #132 (comment), returning/throwing the message string is not an ideal solution – instead, make console.log print only the message. If you can update this PR, I can merge it :)

@addaleax
Copy link
Collaborator

I think this has been fixed now, so I’m closing this. Please feel free to re-open if you run into any more trouble!

@addaleax addaleax closed this Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants