-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to make it possible for errors to match #106
Conversation
The previous version would output the entire error object, making it impossible to match (with the file paths). Using `e.message` instead makes sure the error matches. I believe it works with the intent of the test (and builds on the use of `error.message` earlier.
Yup, this solves the problem 👍 |
this solution did not work for me. it reduced the output to the message property, while the program is still comparing the entire object.
|
Is there any way we can get this merged? I have been working with someone and it's a bit of an impediment to progress when training. It's especially hard when you're working with a relative beginner and you have to explain to them what a stack trace is when you're already working with complex concepts 😫 |
@donovanh thanks for the info, I'll reach out to steven 👍 |
I cannot get passed this exercise due to this issue. It throws an error, but my stacktrace doesn't match the solution's, so indefinitely stuck here. 😭 Any way I can help? |
@traumverloren, change the original solution file as shown here: 95ac56a |
I think this has been fixed now, so I’m closing this. Please feel free to re-open if you run into any more trouble! |
The previous version would output the entire error object, making it impossible to match (with the file paths).
Using
e.message
instead makes sure the error matches. I believe it works with the intent of the test (and builds on the use oferror.message
earlier.