Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace GetLatestLedgerSequence calls with GetLedgerRange #246

Closed
wants to merge 9 commits into from

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Jul 10, 2024

What

#233

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@aditya1702 aditya1702 changed the title [WIP] Replace GetLatestLedgerSequence function with GetLedgerRange [WIP] Replace GetLatestLedgerSequence calls with GetLedgerRange Jul 10, 2024
@2opremio
Copy link
Contributor

I don't think there is a need to replace the calls. I think the GetLatestLedger functions can (and should) exist. It's just the internal implementation which should change.

@aditya1702 aditya1702 closed this Jul 25, 2024
@aditya1702 aditya1702 deleted the remove-latest-ledger-key branch July 25, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants