Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: Remove latestledger key from meta table #233

Closed
2opremio opened this issue Jun 27, 2024 · 1 comment · Fixed by #256
Closed

db: Remove latestledger key from meta table #233

2opremio opened this issue Jun 27, 2024 · 1 comment · Fixed by #256
Assignees
@aditya1702
Labels
rpc-sdk-scrum
Milestone
platform sprint 50

Comments

@2opremio
Copy link
Contributor

2opremio commented Jun 27, 2024 •
edited
Loading

The meta table contains the LatestLedgerSequence key, which can simply be obtained from the ledger table (GetLedgerRange)

This will also require updating the db API and, while we are at it, cache the full range, not just the latest ledger

Tasks
Preview Give feedback
No tasks being tracked yet.
@2opremio 2opremio mentioned this issue Jun 28, 2024
Merged
@aditya1702 aditya1702 moved this from Backlog to To Do in Platform Scrum Jul 2, 2024
@2opremio
Copy link
Contributor Author

2opremio commented Jul 8, 2024

We actually cannot remove the table itself, because now we are using it to store the migration state. But ... we should remove the latestledger key.

@2opremio 2opremio changed the title db: Remove meta table db: Remove latestledger key from meta table Jul 8, 2024
@aditya1702 aditya1702 mentioned this issue Jul 10, 2024
Closed
@Shaptic Shaptic mentioned this issue Jul 11, 2024
Closed
@aditya1702 aditya1702 moved this from To Do to In Progress in Platform Scrum Jul 25, 2024
@aditya1702 aditya1702 mentioned this issue Jul 30, 2024
Merged
@aditya1702 aditya1702 moved this from In Progress to Needs Review in Platform Scrum Aug 26, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aditya1702 aditya1702

Labels
rpc-sdk-scrum
Projects
Platform Scrum
Status: Done
Milestone
platform sprint 50
Development

Successfully merging a pull request may close this issue.

Optimise db performance of GetLedgerRange aditya1702/soroban-rpc
4 participants
@Shaptic @mollykarcher @2opremio @aditya1702