Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove unneeded logic #157

Merged
merged 2 commits into from
May 1, 2024

Conversation

willemneal
Copy link
Member

@willemneal willemneal commented Apr 23, 2024

fixes #156

  • Removes signing

  • Removes parsing the wasm

  • Update send_transaction to return the transaction hash and then provide a polling alternative to get the final transaction.

  • Removes dependencies on stellar-sdk, soroban-spec, ed25519-dalek,

    • Went from 282 total dependencies to 170, and cold start build times went from 40s to 26s.
  • Reduces clap feature set

  • Update Client struct to include the Arc<HttpClient> and Arc<str>, allowing the struct to implement clone. Perviously the HttpClient would be constructed each time it was needed of once when Client was constructed.

@willemneal willemneal marked this pull request as ready for review April 23, 2024 18:51
Including signing and ensure that RPC methods are pure
@willemneal willemneal force-pushed the feat-make-API-pure-and-provide-no-additional-logic branch from 1377d22 to dcfc0d1 Compare April 25, 2024 18:49
@willemneal willemneal merged commit 587a229 into main May 1, 2024
20 checks passed
@willemneal willemneal deleted the feat-make-API-pure-and-provide-no-additional-logic branch May 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stellar-rpc-client] Remove parsing of wasm and signing
3 participants