Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stellar-rpc-client] Remove parsing of wasm and signing #156

Closed
2 tasks
willemneal opened this issue Apr 23, 2024 · 0 comments · Fixed by #157
Closed
2 tasks

[stellar-rpc-client] Remove parsing of wasm and signing #156

willemneal opened this issue Apr 23, 2024 · 0 comments · Fixed by #157
Assignees
@willemneal

Comments

@willemneal
Copy link
Member

The crate should only provide access to RPC an no extra logic.

  • Remove references to soroban_sdk and any code used to parse raw data returned by the RPC
    @willemneal could you push out the wasm spec lookup to soroban-cli?

Originally posted by @2opremio in #149 (comment)

  • Remove all logic around signing
@willemneal willemneal mentioned this issue Apr 23, 2024
Merged
@willemneal willemneal self-assigned this Apr 23, 2024
@willemneal willemneal added this to DevX Apr 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DevX Apr 23, 2024
@willemneal willemneal moved this from Backlog to Needs Review in DevX Apr 23, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in DevX May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willemneal willemneal

Labels
None yet
Projects
DevX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: remove unneeded logic stellar/stellar-rpc
1 participant
@willemneal