Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflow for unit tests in internal package #130

Merged
merged 6 commits into from
Aug 16, 2021

Conversation

acharb
Copy link
Contributor

@acharb acharb commented Aug 16, 2021

WHAT
adding automated unit testing for the internal package.

WHY
ensures code that's merged into master is tested.

closes #125

@acharb acharb marked this pull request as ready for review August 16, 2021 21:35
Copy link
Contributor

@sydneynotthecity sydneynotthecity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Just some questions for my understanding and one idea

.github/workflows/internal.yml Outdated Show resolved Hide resolved
.github/workflows/internal.yml Show resolved Hide resolved
.github/workflows/internal.yml Outdated Show resolved Hide resolved
@acharb acharb merged commit 11032cd into master Aug 16, 2021
@acharb
Copy link
Contributor Author

acharb commented Aug 16, 2021

btw terraform PR for blocking merges if these tests fail here:
https://github.com/stellar/terraform/pull/504

@sydneynotthecity sydneynotthecity deleted the acharb-autotest branch August 23, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated testing
2 participants