Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate and fix cmd unit tests #131

Closed
acharb opened this issue Aug 16, 2021 · 3 comments
Closed

investigate and fix cmd unit tests #131

acharb opened this issue Aug 16, 2021 · 3 comments
Assignees

Comments

@acharb
Copy link
Contributor

acharb commented Aug 16, 2021

some of the unit tests in cmd are failing, but I'm not sure if it's code we are still using. eg. TestExportChanges/changes_from_single_ledger using export_ledger_entry_changes (are we using this command anywhere?). Investigate if these command are something we still need and if so fix.

Once the cmd unit testing works we can add to the github workflow for automated testing (pr for reference)

@sydneynotthecity sydneynotthecity self-assigned this Aug 17, 2021
@sydneynotthecity
Copy link
Contributor

Fixed the export_transactions and export_operations tests. The other broken tests require a working captive core, which i'm still working on.

@sydneynotthecity
Copy link
Contributor

@amishas157 we can close this ticket, correct? I believe #274 resolved

@amishas157
Copy link
Contributor

Yes., the docs for running tests are available in https://github.com/stellar/stellar-etl?tab=readme-ov-file#running-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants