Add standalone check-quorum-intersection command
#4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboston7
force-pushed
the
quorum-intersection
branch
from
dfa907f
to
89f5d0a
Compare
nano-o
reviewed
Dec 19, 2023
nano-o
reviewed
Dec 19, 2023
bboston7
force-pushed
the
quorum-intersection
branch
2 times, most recently
from
8479096
to
31dcd9a
Compare
marta-lokhova
approved these changes
Dec 22, 2023
Closes stellar#4062 This change adds a command `check-quorum-intersection` that takes a JSON file produced by the `quorum` endpoint and checks whether it enjoys a quorum intersection. Most of the change centers around reading JSON in, but this change also required refactoring `QuorumIntersectionChecker` to use a map from `NodeID` to `SCPQuorumSetPtr` instead of a map from `NodeID` to `NodeInfo`, as the intersection checking only relies on the `mQuorumSet` field of a `QuorumMap` and the JSON input does not contain everything in `NodeInfo`.
bboston7
force-pushed
the
quorum-intersection
branch
from
7ebfcf0
to
a93dfe6
Compare
|
This is rebased, squashed, and ready to merge! |
|
r+ a93dfe6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4062
This change adds a command
check-quorum-intersectionthat takes a JSON file produced by thequorumendpoint and checks whether it enjoys a quorum intersection.Most of the change centers around reading JSON in, but this change also required refactoring
QuorumIntersectionCheckerto use a map fromNodeIDtoSCPQuorumSetPtrinstead of a map fromNodeIDtoNodeInfo, as the intersection checking only relies on themQuorumSetfield of aQuorumMapand the JSON input does not contain everything inNodeInfo.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)