-
Notifications
You must be signed in to change notification settings - Fork 970
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add standalone
check-quorum-intersection
command
Closes #4062 This change adds a command `check-quorum-intersection` that takes a JSON file produced by the `quorum` endpoint and checks whether it enjoys a quorum intersection. Most of the change centers around reading JSON in, but this change also required refactoring `QuorumIntersectionChecker` to use a map from `NodeID` to `SCPQuorumSetPtr` instead of a map from `NodeID` to `NodeInfo`, as the intersection checking only relies on the `mQuorumSet` field of a `QuorumMap` and the JSON input does not contain everything in `NodeInfo`.
- Loading branch information
Showing
16 changed files
with
480 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
a93dfe6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from marta-lokhova
at bboston7@a93dfe6
a93dfe6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging bboston7/stellar-core/quorum-intersection = a93dfe6 into auto
a93dfe6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bboston7/stellar-core/quorum-intersection = a93dfe6 merged ok, testing candidate = 778a00c
a93dfe6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19904471654
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903491109
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490912
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490718
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490579
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490424
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490280
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490151
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903490029
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903489898
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903489778
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903489659
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903489516
success: https://github.com/stellar/stellar-core/actions/runs/7303286119/job/19903489319
a93dfe6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 778a00c