Loadgen startup fix #4087
Loadgen startup fix #4087
Conversation
src/simulation/LoadGenerator.cpp
Outdated
| LoadGenerator::start(GeneratedLoadConfig& cfg) | ||
| { | ||
| // Setup config for soroban modes | ||
| if (!mStarted && cfg.isSoroban()) |
There was a problem hiding this comment.
start should be a no-op except on the first invocation, so why not add if (mStarted) return; at the beginning and get rid of the checks in the individual ifs. Currently the only functions that get called multiple times in start are createRootAccount and updateMinBalance. If we need to call those periodically they probably don't belong in start (but I don't think we do).
src/simulation/LoadGenerator.cpp
Outdated
| GeneratedLoadConfig::areTxsRemaining() const | ||
| { | ||
| return (isCreate() && nAccounts != 0) || (!isCreate() && nTxs != 0); | ||
| createRootAccount(); |
There was a problem hiding this comment.
Now that we have a single start function, we should change if (!mRoot) to releaseAssert(!mRoot) in createRootAccount().
src/simulation/LoadGenerator.cpp
Outdated
| &VirtualTimer::onFailureNoop); | ||
| } | ||
| else | ||
| if (!mStartTime) |
There was a problem hiding this comment.
I think we should change this to releaseAssert(!mStartTime) (assuming you implement my other comment where we exit early in start()).
marta-lokhova
force-pushed
the
loadgen_race_cond
branch
2 times, most recently
from
498c2da
to
ad064ba
Compare
|
@SirTyson added your suggestions, so this should be ready now |
marta-lokhova
force-pushed
the
loadgen_race_cond
branch
from
ad064ba
to
fce809d
Compare
|
r+ fce809d |
Resolves #4071