Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load generator: race condition on startup #4071

Closed
marta-lokhova opened this issue Nov 30, 2023 · 0 comments · Fixed by #4087
Closed

load generator: race condition on startup #4071

marta-lokhova opened this issue Nov 30, 2023 · 0 comments · Fixed by #4087
Assignees
Labels

Comments

@marta-lokhova
Copy link
Contributor

Load generator does some state setup in scheduleLoadGeneration. Without the setup, we can't generate load correctly (for example, we can't generate load if we don't populate available accounts to choose from). However, it looks like core triggers load generation via generateLoad rather than scheduleLoadGeneration. Most of the time the first call to generateLoad is a no-op, since we compute the amount of load to generate based on elapsed time, but occasionally if the function takes a bit longer, we try to generate load and fail due to inadequate setup. We should refactor the startup code such that we perform all the necessary setup in the first call to generateLoad (and not in scheduleLoadGeneration, as it should only be in charge of rescheduling the callback)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant