Centralize txn size calculation #4064
Conversation
There was a problem hiding this comment.
Thanks for this cleanup! I think there are a few more places in the code where we should be using the new getTransactionEnvelopeSize instead of the old calculation. I see some places in src/herder/test/HerderTests.cpp, src/transactions/test/InvokeHostFunctionTests.cpp, and src/transactions/test/SorobanTxTestUtils.cpp. Any place where we have xdr::xdr_size(txEnvelope) should probably use the new function for consistency.
| if (isSoroban()) | ||
| { | ||
| auto txSize = static_cast<int64_t>( |
There was a problem hiding this comment.
Why did this move inside the if? Seems cleaner to get the size just once like before.
There was a problem hiding this comment.
We don't use the size in the final else case (non-soroban, non-useByteLimitInClassic), so I moved the computation into the cases where we are using it. But I agree its cleaner to only have the computation in one place.
There was a problem hiding this comment.
looks like txSize is still calculated twice
ThomasBrady
force-pushed
the
4023-centralize-transaction-size-computation
branch
3 times, most recently
from
fedd472
to
170b87a
Compare
ThomasBrady
force-pushed
the
4023-centralize-transaction-size-computation
branch
from
23c49dd
to
b44f884
Compare
|
r+ b44f884 |
…from txn and overlay systems
Description
Resolves #4023
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)