You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Multiple subsystems in core rely on transaction size computation. For these systems to interact correctly, they must compute tx size in the same way. We've already encountered bugs related to the fact that core has several places where the same computation is done, e.g. in overlay:
Multiple subsystems in core rely on transaction size computation. For these systems to interact correctly, they must compute tx size in the same way. We've already encountered bugs related to the fact that core has several places where the same computation is done, e.g. in overlay:
stellar-core/src/overlay/FlowControlCapacity.cpp
Line 223 in 0448bf0
and in tx the subsystem:
stellar-core/src/transactions/TransactionFrame.cpp
Line 227 in 0448bf0
We should centralize this logic in one util function to prevent footguns.
The text was updated successfully, but these errors were encountered: