Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup, fixes to tx queue #3963

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Code cleanup, fixes to tx queue #3963

merged 5 commits into from
Oct 16, 2023

Conversation

marta-lokhova
Copy link
Contributor

Couple changes from code review:

  • Deprecate FIRST_VERSION_SUPPORTING_GENERALIZED_TX_SET, as minimum overlay version is past it at this point
  • Some renaming for clarity
  • Most importantly, some fixes to tx queue: ensure we properly reject unsupported Soroban transactions when in protocol v19 (this can occur on lagging nodes that haven't upgraded yet). To further strengthen the code, initialize Soroban queue post-v20-upgrade. This way we ensure we don't call any functions on Soroban tx queue before the upgrade. This allows us to remove some protocolVersion checks (specifically, in flooding).

dmkozh
dmkozh reviewed Oct 14, 2023
View reviewed changes
src/herder/HerderImpl.h Outdated Show resolved Hide resolved
src/herder/HerderImpl.cpp Show resolved Hide resolved
src/herder/test/HerderTests.cpp Show resolved Hide resolved
src/overlay/Peer.cpp Show resolved Hide resolved
@dmkozh
Copy link
Contributor

dmkozh commented Oct 16, 2023

r+ 1655657

@marta-lokhova
Copy link
Contributor Author

CI failed due to DEFAULT_TEST_REFUNDABLE_FEE -> DEFAULT_TEST_RESOURCE_FEE rename in master, fixing.

@dmkozh
Copy link
Contributor

dmkozh commented Oct 16, 2023

r+ 69a69b0

@latobarita latobarita merged commit 8e4c44f into stellar:master Oct 16, 2023
6 checks passed
@marta-lokhova marta-lokhova mentioned this pull request Nov 17, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh left review comments

@sisuresh sisuresh Awaiting requested review from sisuresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marta-lokhova @dmkozh @latobarita