Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] submit invalid soroban transactions to tx queue #4006

Closed
3 tasks done
marta-lokhova opened this issue Nov 1, 2023 · 1 comment
Closed
3 tasks done

[test] submit invalid soroban transactions to tx queue #4006

marta-lokhova opened this issue Nov 1, 2023 · 1 comment
Assignees
@marta-lokhova
Labels
enhancement

Comments

@marta-lokhova
Copy link
Contributor

marta-lokhova commented Nov 1, 2023 •
edited
Loading

Ensure invalid Soroban transactions do not crash the queue or cause UB. Tx queue determines if the transaction can be added based on ledger limits first, before actually checking its validity. Therefore, test the following:

  • Transactions with unbounded resources do not cause overflow
  • Invalid fees (such as 0 or negative) are handled correctly
  • Soroban transactions received in v19 are handled gracefully
@marta-lokhova marta-lokhova self-assigned this Nov 3, 2023
@marta-lokhova
Copy link
Contributor Author

resolved via #4010 and #3963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marta-lokhova marta-lokhova

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marta-lokhova