Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md for MacOS #3708

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Update INSTALL.md for MacOS #3708

merged 2 commits into from
Apr 20, 2023

Conversation

sisuresh
Copy link
Contributor

Description

Related to #3707

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

INSTALL.md Outdated
@@ -111,7 +111,7 @@ In order to install the llvm (clang) toolchain, you may have to follow instructi
When building on OSX, here's some dependencies you'll need:
- Install xcode
- Install [homebrew](https://brew.sh)
- `brew install libsodium libtool autoconf automake pkg-config libpq openssl parallel ccache bison sed perl`
- `brew install libsodium libtool autoconf automake pkg-config libpq openssl parallel ccache bison sed perl coreutils`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no sed package. using gnu-sed instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sisuresh
Copy link
Contributor Author

@tsachiherman did you have to update your path for gnu-sed?

@tsachiherman
Copy link
Contributor

@tsachiherman did you have to update your path for gnu-sed?

No; it was working right away.

@MonsieurNicolas
Copy link
Contributor

r+ b226ec5

@latobarita latobarita merged commit 109141e into stellar:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants