Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make doesn't fail when sha256sum is missing #3707

Closed
sisuresh opened this issue Apr 18, 2023 · 1 comment
Closed

Make doesn't fail when sha256sum is missing #3707

sisuresh opened this issue Apr 18, 2023 · 1 comment
Labels
bug

Comments

@sisuresh
Copy link
Contributor

When we build with Soroban enabled on Mac OS, this line will do nothing if sha256sum is not installed. The issue is that make will just continue, and we'll see an xdr mismatch later. We should get make to fail on that line. I tried set -eo pipeline, which fails if sha256sum is missing, but if sha256sum is there, the bash script ends on that line and the generated file is missing the braces echoed after that line.
@sisuresh sisuresh added the bug label Apr 18, 2023
@sisuresh sisuresh mentioned this issue Apr 18, 2023
Merged
6 tasks
@sisuresh sisuresh mentioned this issue Nov 6, 2023
Merged
@sisuresh
Copy link
Contributor Author

sisuresh commented Nov 8, 2023

Resolved by #4014

@sisuresh sisuresh closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sisuresh