Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tx set frame order matter only during encoding/decoding. #3496

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Make tx set frame order matter only during encoding/decoding. #3496

merged 1 commit into from
Aug 25, 2022

Commits on Aug 24, 2022

  1. Make tx set frame order matter only during encoding/decoding. 

    There is no reason to maintain the order in memory and then implicitly assume it's preserved during encoding. Instead, we store transactions in arbitrary order in memory and sort only during encoding to XDR. This hopefully should reduce the risk of outputting a malformed tx set.

For additional safety, we do the XDR roundtrip during the in-memory tx set construction, so we guarantee that we never nominate malformed tx set XDR (at least from the standpoint of the particular core version).
    @dmkozh
    dmkozh committed Aug 24, 2022
    5 Configuration menu
    Copy the full SHA
    1f5d4bc View commit details
    Browse the repository at this point in the history