Make tx set frame order matter only during encoding/decoding. #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
requested changes
Aug 24, 2022
| @@ -2377,12 +2377,12 @@ TEST_CASE_VERSIONS("txenvelope", "[tx][envelope]") | |||
|
|
|||
| auto r = closeLedgerOn(*app, 1, 2, 2016, {tx1, tx2}); | |||
|
|
|||
| REQUIRE(tx1->getResultCode() == txSUCCESS); | |||
| REQUIRE(tx2->getResultCode() == txFAILED); | |||
| checkTx(0, r, txSUCCESS); | |||
There was a problem hiding this comment.
I think you need to pass true to the last arg of closeLedgerOn, otherwise you don't know if tx1 < tx2
There was a problem hiding this comment.
I don't think so: results are in the apply order (I've double-checked with the debugger). The last arg of closeLedgerOn makes the txs to be applied in the same order as we have passed to the method (which already happens due to seq nums) and it has nothing to do with the result order.
There was a problem hiding this comment.
Ah didn't see that tx1 and tx2 were from the same account!
There is no reason to maintain the order in memory and then implicitly assume it's preserved during encoding. Instead, we store transactions in arbitrary order in memory and sort only during encoding to XDR. This hopefully should reduce the risk of outputting a malformed tx set. For additional safety, we do the XDR roundtrip during the in-memory tx set construction, so we guarantee that we never nominate malformed tx set XDR (at least from the standpoint of the particular core version).
dmkozh
force-pushed
the
improve_tx_set_frame
branch
from
604a55c
to
1f5d4bc
Compare
|
r+ 1f5d4bc |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3495
Make tx set frame order matter only during encoding/decoding.
There is no reason to maintain the order in memory and then implicitly assume it's preserved during encoding. Instead, we store transactions in arbitrary order in memory and sort only during encoding to XDR. This hopefully should reduce the risk of outputting a malformed tx set.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)