Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: adapt to value overhaul changes #523

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Mar 21, 2023

What

Adapt soroban-rpc to the new value overhaul XDR changes (that is stellar/go#4814 , which in turn comes from stellar/stellar-xdr#70 )

Why

It's part of #471

It closes #477

Known limitations

TODO:

  • fix integration tests (it requires bumping the core build)

@2opremio
Copy link
Contributor Author

Related #516

@paulbellamy should I retarget the merge to the branch in the PR above?

@2opremio 2opremio force-pushed the soroban-rpc-value-overhaul branch from 859b92a to 7369bdb Compare March 21, 2023 10:29
@2opremio
Copy link
Contributor Author

2opremio commented Mar 21, 2023

Integration tests are failing due to an OOM panic:

fatal error: runtime: out of memory

runtime stack:
runtime.throw({0x1c232d8?, 0x804000000?})
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/panic.go:1047 +0x5d fp=0x7fd75affdc20 sp=0x7fd75affdbf0 pc=0x5c8ddd
runtime.sysMapOS(0xc003400000, 0x800400000?)
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/mem_linux.go:187 +0x11b fp=0x7fd75affdc68 sp=0x7fd75affdc20 pc=0x5a9adb
runtime.sysMap(0x2e42180?, 0xc3ffffffff?, 0x2e52318?)
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/mem.go:142 +0x35 fp=0x7fd75affdc98 sp=0x7fd75affdc68 pc=0x5a94b5
runtime.(*mheap).grow(0x2e42180, 0x400002?)
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/mheap.go:1522 +0x245 fp=0x7fd75affdd10 sp=0x7fd75affdc98 pc=0x5b9c65
runtime.(*mheap).allocSpan(0x2e42180, 0x400002, 0x0, 0x0?)
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/mheap.go:1243 +0x1b7 fp=0x7fd75affdda8 sp=0x7fd75affdd10 pc=0x5b93b7
runtime.(*mheap).alloc.func1()
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/mheap.go:961 +0x65 fp=0x7fd75affddf0 sp=0x7fd75affdda8 pc=0x5b8e65
runtime.systemstack()
	/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/asm_amd64.s:496 +0x49 fp=0x7fd75affddf8 sp=0x7fd75affddf0 pc=0x5feda9

@2opremio
Copy link
Contributor Author

2opremio commented Mar 21, 2023

Now that I think about it, integration tests cannot succeed without #516 (since we need to update the test contracts).

However, we shouldn't be running out of memory.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.
It's unfortunate that these changes were needed, but I can think of any way would could have avoided these.

@2opremio 2opremio marked this pull request as ready for review March 21, 2023 14:40
@2opremio 2opremio merged commit de8afa7 into stellar:main Mar 21, 2023
@2opremio 2opremio deleted the soroban-rpc-value-overhaul branch March 21, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants