Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDR Value Overhaul updates #516

Merged
merged 8 commits into from
Mar 21, 2023
Merged

XDR Value Overhaul updates #516

merged 8 commits into from
Mar 21, 2023

Conversation

paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Mar 15, 2023

Staging branch for xdr value updates work on soroban-cli and soroban-rpc.

We can PR changes here, and get it working before merging to main.

TODO

  • update soroban-cli
  • update soroban-rpc
    • fix simulate_transaction_test.go breakages

willemneal and others added 2 commits March 15, 2023 14:59
* fix: add back type def parsing for return val

* fix: switch to eprintln

* chore: narrowed down failing case

* fix: update to env fix

* chore: clean up test wasm

Removed unneeded test wasm methods.

* chore: remove unneeded comment

* fix: removed unneeded unknown error
@paulbellamy paulbellamy marked this pull request as ready for review March 21, 2023 10:32
@paulbellamy paulbellamy enabled auto-merge (squash) March 21, 2023 14:37
@paulbellamy paulbellamy merged commit b98e4b5 into main Mar 21, 2023
@paulbellamy paulbellamy deleted the xdr-update branch March 21, 2023 15:17
2opremio added a commit to 2opremio/soroban-cli that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants