Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings-ts): update to latest stellar-sdk & typescript; test in CI #1037

Merged
merged 1 commit into from
Jan 12, 2024
Merged

chore(bindings-ts): update to latest stellar-sdk & typescript; test in CI #1037

merged 1 commit into from
Jan 12, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Oct 19, 2023 •
edited
Loading

What

Why

  • CI will make sure the TS bindings stay functional
  • latest deps r good

Known limitations

[TODO or N/A]

@chadoh chadoh mentioned this pull request Oct 19, 2023
Closed
1 task
@chadoh chadoh mentioned this pull request Nov 20, 2023
Open
@chadoh chadoh changed the base branch from main to release/v20.0.0-rc.4.2 November 20, 2023 19:03
@chadoh
Copy link
Contributor Author

chadoh commented Dec 14, 2023

Most of these tests will be moving to stellar-sdk soon as part of stellar/js-stellar-sdk#891. I'll circle back and update this PR with any needed changes after that lands.

@mollykarcher mollykarcher added the cli Related to Soroban CLI label Dec 14, 2023
@chadoh chadoh mentioned this pull request Dec 14, 2023
Closed
@chadoh
Copy link
Contributor Author

chadoh commented Jan 4, 2024

Will be implemented as part of stellar/js-stellar-sdk#891, wherever it ends up living

@chadoh chadoh closed this Jan 4, 2024
@chadoh chadoh deleted the build/ci-bindings-ts branch January 4, 2024 20:41
@chadoh chadoh restored the build/ci-bindings-ts branch January 4, 2024 20:43
@chadoh
Copy link
Contributor Author

chadoh commented Jan 4, 2024

Actually, we may still want a few tests here. No reason to wait on implementing this; I'll get back to it now that stellar/quickstart#540 has been released.

@chadoh chadoh reopened this Jan 4, 2024
@chadoh chadoh changed the base branch from release/v20.0.0-rc.4.2 to main January 5, 2024 17:03
@chadoh chadoh marked this pull request as ready for review January 5, 2024 17:06
@chadoh
Copy link
Contributor Author

chadoh commented Jan 5, 2024

Looks like most of the jobs are not running right now. Not sure why. @mollykarcher do I just need to wait a little while longer, or did I do something wrong?

@mollykarcher mollykarcher reopened this Jan 5, 2024
@mollykarcher
Copy link
Contributor

@chadoh I'm honestly not sure what/if you did anything wrong. Perhaps some weird github idiosyncrasy with the combo of retargetting + force pushing + move from draft sequence. Close/reopen on my part seems to have kicked it off though

@chadoh chadoh force-pushed the build/ci-bindings-ts branch 7 times, most recently from 5941422 to 76015c6 Compare January 11, 2024 22:35
@chadoh chadoh changed the title build: add bindings ts tests to ci chore(bindings-ts): update to latest stellar-sdk & typescript; test in CI Jan 11, 2024
Shaptic
Shaptic approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a

make typescript-bindings-fixtures

run but otherwise it's good2go.

If you took this opportunity to stellar-sdk ➡️ @stellar/stellar-sdk, though, it would shrink the number of dependency dupes and possible XDR mismatches (since @stellar/freighter-api uses the @stellar/ variant). Should be an easy set of renames!

I'll approve nonetheless.

This was referenced Jan 11, 2024
Closed
Merged
@socket-security Socket Security
Copy link

socket-security bot commented Jan 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@stellar/stellar-sdk 11.2.0 None +0 3.51 MB

🚮 Removed packages: [email protected], [email protected]

@Shaptic Shaptic changed the base branch from main to release/v20.2.0 January 12, 2024 00:04
@chadoh
build: add bindings ts tests to ci
dbb8d5f 
Add tests from #11 which didn't make it into stellar#973 due to the quickstart image not starting properly in CI.

Adding this directly to stellar#973 was costing too much time. We can troubleshoot quickstart issues here.

Update for latest changes from `soroban config identity` to `soroban
keys`
@chadoh
Copy link
Contributor Author

chadoh commented Jan 12, 2024

Good idea with the @stellar/stellar-sdk switch. Updated!

@Shaptic Shaptic merged commit 8276238 into stellar:release/v20.2.0 Jan 12, 2024
25 checks passed
Shaptic added a commit that referenced this pull request Jan 12, 2024
@Shaptic
Merge pull request #1163 from stellar/release/v20.2.0
7ee51fa 
* Bump version to 20.2.0 (#1163)
* Bump Core and dependency versions to the official tags/images (#1164)
* Update the Stellar SDK for the latest TypeScript bindings (#1037)
@chadoh chadoh deleted the build/ci-bindings-ts branch January 12, 2024 12:19
@chadoh chadoh mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees

@chadoh chadoh

Labels
cli Related to Soroban CLI
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadoh @mollykarcher @Shaptic