Fix unintended environment variable config passthrough to services #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a81b95.
leighmcculloch
changed the title
This was referenced Jan 3, 2024
tomerweller
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run supervisord in a new environment that doesn't inherit the shell.
Why
Supervisord and its subprocesses inherit the shell's environment variables.
This is problematic since environment variables are a shared space and there's no guarantee that setting an environment variable would make sense for all sub processes.
We have a case where this has caused problems. The quickstart image uses the
NETWORKenvironment variable, and so does Horizon. For the longest time we have had issues running the quickstart image in certain situations, and it turns out what those situations had in common was they were setting the network of the image via an environment variableNETWORKto a value that worked with the quickstart image start script but didn't work with Horizon. Some values worked for both, some didn't.We should set environment variables for services explicitly, not broadly based on what the images env vars are.
This will allow us to use the quickstart image as a service in GitHub Actions where it must be configured using env vars,
and anywhere folks are already configuring it with env vars.
Close #541