Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-cli: output diagnostic events from CLI #476

Closed
tsachiherman opened this issue Mar 6, 2023 · 4 comments · Fixed by #539
Closed

soroban-cli: output diagnostic events from CLI #476

tsachiherman opened this issue Mar 6, 2023 · 4 comments · Fixed by #539
Assignees

Comments

@tsachiherman
Copy link
Contributor

What ?

soroban-cli: output debug events from CLI

Epic

#471

@2opremio
Copy link
Contributor

I presume this only refers to soroban invoke since we have a specific ticket for getting the events ( #473 )

As a result of this ticket soroban invoke should:

  1. Print the debug events of simulateTransaction
  2. Print the debug events when sending the transaction (sendTransaction). This may require some syncing with soroban-rpc.

I am not sure whether (1) is useful if the transaction submission succeeds (since I presume the debug events will be identical)

We may or may not want to print the debug events of soroban deploy (which also submits a transaction which may generates events).

@tsachiherman
Copy link
Contributor Author

I agree that int he case of soroban invoke, it might not be very useful to see the debug events output of the simulateTransaction. However, I think that we missed something here : we should create a ticket for adding support returning debug events from sendTransaction, right ?

@2opremio
Copy link
Contributor

I don’t think sendTransaction can output events directly. I think we would need for txmeta to arrive after the transaction is included.

@tamirms isn't that the case?

@tamirms
Copy link
Contributor

tamirms commented Mar 13, 2023

@2opremio that's right. I think the client can only expect to have debug events on getTransaction()

@tsachiherman tsachiherman changed the title soroban-cli: output debug events from CLI soroban-cli: output diagnostic events from CLI Mar 15, 2023
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Mar 20, 2023
@2opremio 2opremio self-assigned this Mar 28, 2023
@2opremio 2opremio moved this from Next Sprint Proposal to In Progress in Platform Scrum Mar 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants