Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: update getEvents query to support optional diagnostic events #473

Closed
tsachiherman opened this issue Mar 6, 2023 · 0 comments · Fixed by #530
Closed

soroban-rpc: update getEvents query to support optional diagnostic events #473

tsachiherman opened this issue Mar 6, 2023 · 0 comments · Fixed by #530
Assignees
@2opremio
Labels
soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023 •
edited by paulbellamy
Loading

What

soroban-rpc: update getEvents query to support optional debug events

We should include any emitted diagnostic events alongside the normal contract events (if they are in storage). We'll need to add a new event type for this to filter.

Note: They will already have been ingested & stored alongside normal events in #472

Question: Should we return a value indicating that diagnostic events are enabled?

Epic

#471
@tsachiherman tsachiherman mentioned this issue Mar 6, 2023
Closed
This was referenced Mar 10, 2023
Closed
Closed
@mollykarcher mollykarcher mentioned this issue Mar 13, 2023
Closed
@tsachiherman tsachiherman changed the title soroban-rpc: update getEvents query to support optional debug events soroban-rpc: update getEvents query to support optional diagnostic events Mar 15, 2023
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Mar 20, 2023
@tamirms tamirms self-assigned this Mar 23, 2023
@tamirms tamirms moved this from Next Sprint Proposal to In Progress in Platform Scrum Mar 23, 2023
@tamirms tamirms moved this from In Progress to Current Sprint in Platform Scrum Mar 23, 2023
@tamirms tamirms moved this from Current Sprint to In Progress in Platform Scrum Mar 23, 2023
@2opremio 2opremio assigned 2opremio and unassigned tamirms Mar 23, 2023
@2opremio 2opremio mentioned this issue Mar 23, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2opremio 2opremio

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

soroban-rpc: Add filtering support for diagnostic events 2opremio/soroban-cli
4 participants
@paulbellamy @tamirms @2opremio @tsachiherman