Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: emit diagnostic events from simulateTransaction #475

Closed
tsachiherman opened this issue Mar 6, 2023 · 1 comment · Fixed by #534
Closed

soroban-rpc: emit diagnostic events from simulateTransaction #475

tsachiherman opened this issue Mar 6, 2023 · 1 comment · Fixed by #534
Assignees
@2opremio
Labels
soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023 •
edited
Loading

What

soroban-rpc: emit debug events from simulateTransaction

How

  • Bump the env-host Rust dependency
  • Modify libpreflight to also return the preflight events (both the old and the new ones)
  • Modify the SimulateTransactionResponse data structure ( how ? )
  • Update unit tests ( which ? )
  • Implement the CLI side soroban-cli: output diagnostic events from CLI #476

Epic

#471
@tsachiherman tsachiherman mentioned this issue Mar 6, 2023
Closed
@2opremio
Copy link
Contributor

2opremio commented Mar 10, 2023 •
edited
Loading

As a result. the simulateTransaction JSON response (SimulateTransactionResponse) in soroban-rpc should include the debug events

To do so, we should:

  1. Bump the env-host Rust dependency
  2. Modify libpreflight to also return the preflight events (both the old and the new ones)
  3. Modify the SimulateTransactionResponse data structure
  4. Implement the CLI side soroban-cli: output diagnostic events from CLI #476

@2opremio 2opremio mentioned this issue Mar 10, 2023
Closed
@tsachiherman tsachiherman changed the title soroban-rpc: emit debug events from simulateTransaction soroban-rpc: emit diagnostic events from simulateTransaction Mar 15, 2023
@mollykarcher mollykarcher moved this from Backlog to Next Sprint Proposal in Platform Scrum Mar 20, 2023
@2opremio 2opremio self-assigned this Mar 27, 2023
@2opremio 2opremio mentioned this issue Mar 27, 2023
Merged
1 task
@paulbellamy paulbellamy moved this from Next Sprint Proposal to In Progress in Platform Scrum Mar 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Platform Scrum Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2opremio 2opremio

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

soroban-rpc: Add contract events to simulateTransaction's response 2opremio/soroban-cli
2 participants
@2opremio @tsachiherman