Respect trustline limit in to_classic conversions
#516
Conversation
Sure, I'm aware of this. That's just a cherry-pick from an older branch. |
soroban-env-host/src/host.rs
Outdated
| @@ -1002,6 +1002,7 @@ impl Host { | |||
| let max_balance = i64::MAX; | |||
| (min_balance, max_balance) | |||
| }; | |||
| let max_balance = min(max_balance, tl.limit); | |||
There was a problem hiding this comment.
This excludes the buying liabilities from the limit, rather than reduces the limit by the buying liabilities. Is that correct?
There was a problem hiding this comment.
It seems suspicious to me because this would, I think, mean that you could exceed your limit by canceling things that create buying liabilities.
There was a problem hiding this comment.
Yeah you're right. max_balance should be initialized with tl.limit instead of i64::MAX.
There was a problem hiding this comment.
I think you are right, changed this to apply limit before liabilities.
There was a problem hiding this comment.
This looks good to me. Is this being tested in the follow testing PR referenced previously? @sisuresh can this be merged now?
What
Respect trustline limit in
to_classicconversionsWhy
This is to respect the trustline invariant of balance not exceeding the limit.
Known limitations
N/A