Reduce the amount of roundtrips for built-in token contract #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `AccountId` is decoded straight into XDR, as `AccountId` XDR is a host object type now - `AccountId` is passed around in internal host fns instead of `Object` - Removed `ClassicMetadata` as it became an internal-only structure. Instead, just pass the encoded asset to the contract asset initializer
sisuresh
approved these changes
Oct 3, 2022
jayz22
reviewed
Oct 3, 2022
| pub(crate) fn deserialize_asset(&self, asset: Object) -> Result<Asset, HostError> { | ||
| self.visit_obj(asset, |hv: &Vec<u8>| { | ||
| self.charge_budget(CostType::ValDeser, hv.len() as u64)?; | ||
| Asset::from_xdr(&mut hv.as_slice()) |
There was a problem hiding this comment.
Can you use the metered_from_xdr function instead?
https://github.com/stellar/rs-soroban-env/blob/main/soroban-env-host/src/host/metered_xdr.rs#L50
There was a problem hiding this comment.
That's nice, I've also added an Object helper to avoid visit_obj boilerplate in callers.
jayz22
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
AccountIdis decoded fromRawValstraight into XDR, asAccountIdXDR is a host object type nowAccountIdis passed around in internal host fns instead ofObjectClassicMetadataas it became an internal-only structure. Instead, just pass the encoded asset to the contract asset initializerWhy
This came up during merging the tests with the recently changed code; the recent changes made it pretty hard to understand and use the built-in token due to existence of several 'wrapper' types on the host side. This also addresses #503 partially.
Known limitations
N/A